webForumDet fria alternativet

Problem...

1 svar · 158 visningar · startad av centret

centretMedlem sedan apr. 200148 inlägg
#1

Tjenare alla asp-proffs!
Jag har ett problem här. Den vill inte välja typ. Tex. När man väljer demos som typ så får man även upp trainers.
Så här är databasen uppbygd: http://www.fuskarna.nu/abc.JPG
Här är koden:
<%
typ = request.querystring("sektion")
%>
<!--#include file="adovbs.inc"-->
<META http-equiv="Content-Type" content="text/html; charset=iso-8859-1">

<script language="JavaScript">function info(id) { displayWindow = window.open("info.asp?id=" + id,"displayWindow","toolbar=0,resizable=0,directories=0,status=0,menubar=0,scrollbars=1,location=0,width=270,height=150") }</script>
<center>
<a href="index.asp">Start</A> -
<a href="index.asp?sektion=Demo&bokstav=<%=request("bokstav")%>">Demo</A> -
<a href="index.asp?sektion=Patch&bokstav=<%=request("bokstav")%>">Patch</A> -
<a href="index.asp?sektion=Trainer&bokstav=<%=request("bokstav")%>">Trainer</A> -
<a href="index.asp?sektion=Blandat&bokstav=<%=request("bokstav")%>">Blandat</A>
<br><br>
<a href="index.asp?sektion=<%=typ%>&bokstav=09">0-9</A>
<a href="index.asp?sektion=<%=typ%>&bokstav=a">A</A>
<a href="index.asp?sektion=<%=typ%>&bokstav=b">B</A>
<a href="index.asp?sektion=<%=typ%>&bokstav=c">C</A>
<a href="index.asp?sektion=<%=typ%>&bokstav=d">D</A>
<a href="index.asp?sektion=<%=typ%>&bokstav=e">E</A>
<a href="index.asp?sektion=<%=typ%>&bokstav=f">F</A>
<a href="index.asp?sektion=<%=typ%>&bokstav=g">G</A>
<a href="index.asp?sektion=<%=typ%>&bokstav=h">H</A>
<a href="index.asp?sektion=<%=typ%>&bokstav=i">I</A>
<a href="index.asp?sektion=<%=typ%>&bokstav=j">J</A>
<a href="index.asp?sektion=<%=typ%>&bokstav=k">K</A>
<a href="index.asp?sektion=<%=typ%>&bokstav=l">L</A>
<a href="index.asp?sektion=<%=typ%>&bokstav=m">M</A>
<a href="index.asp?sektion=<%=typ%>&bokstav=n">N</A>
<a href="index.asp?sektion=<%=typ%>&bokstav=o">O</A>
<a href="index.asp?sektion=<%=typ%>&bokstav=p">P</A>
<a href="index.asp?sektion=<%=typ%>&bokstav=q">Q</A>
<a href="index.asp?sektion=<%=typ%>&bokstav=r">R</A>
<a href="index.asp?sektion=<%=typ%>&bokstav=s">S</A>
<a href="index.asp?sektion=<%=typ%>&bokstav=t">T</A>
<a href="index.asp?sektion=<%=typ%>&bokstav=u">U</A>
<a href="index.asp?sektion=<%=typ%>&bokstav=v">V</A>
<a href="index.asp?sektion=<%=typ%>&bokstav=w">W</A>
<a href="index.asp?sektion=<%=typ%>&bokstav=x">X</A>
<a href="index.asp?sektion=<%=typ%>&bokstav=y">Y</A>
<a href="index.asp?sektion=<%=typ%>&bokstav=z">Z</A>
<br><br></center>

<%
If Request.QueryString("bokstav") = "" Then

response.write("<font class=""text"">"&up&"</font><br>")

Set connect = Server.CreateObject("ADODB.Connection")
connect.Open = ""
SQL = "SELECT TOP 6 * FROM files "
if sektion = "" then
SQL = SQL & " order by datum desc"
else
SQL = SQL & " where type = '"&typ&"' order by datum desc"
end if
Set RS = connect.Execute(SQL)
do until rs.eof
%>
<a href="<%=rs("url")%>" onMouseOver="window.status='http://www.fuskarna.nu/filarkiv/\<%=rs("title")%>.zip'; return true" onMouseOut="window.status=''; return true" title="Ladda ner <%=rs("title")%>!" target="_blank"><%=rs("title")%></a><br>
<%
rs.movenext
loop
rs.close
set rs = nothing
connect.close
set connect = nothing

else

Dim I
Dim N
Dim P

If Request.QueryString("page") = "" Then
page = 1
Else
page = CInt( Request.QueryString("page") )
End If

N = page+1
P = page-1

Set connection = Server.CreateObject("ADODB.Connection")
connection.Open = ""

bokstav = request("bokstav")
if bokstav = "09" then
Set rs2 = Server.CreateObject("ADODB.Recordset")

If Request.QueryString("sort") = "" Then
SQL2 = "SELECT * FROM files WHERE ( title like '1%' or title like '0%' or title like '2%' or title like '3%' or title like '4%' or title like '5%' or title like '6%' or title like '7%' or title like '8%' or title like '9%')"
if typ = "" then
else
SQL2 = SQL2 & "AND type = '"&typ&"' "
end if
SQL2 = SQL2 & " Order by title,id Desc"
end if

If Request.QueryString("sort") = "typ" Then
SQL2 = "SELECT * FROM files WHERE ( title like '1%' or title like '0%' or title like '2%' or title like '3%' or title like '4%' or title like '5%' or title like '6%' or title like '7%' or title like '8%' or title like '9%')"
if typ = "" then
else
SQL2 = SQL2 & "AND type = '"&typ&"' "
end if
SQL2 = SQL2 & " Order by type"
end if

If Request.QueryString("sort") = "storlek" Then
SQL2 = "SELECT * FROM files WHERE ( title like '1%' or title like '0%' or title like '2%' or title like '3%' or title like '4%' or title like '5%' or title like '6%' or title like '7%' or title like '8%' or title like '9%')"
if typ = "" then
else
SQL2 = SQL2 & "AND type = '"&typ&"' "
end if
SQL2 = SQL2 & " Order by storlek"
end if

If Request.QueryString("sort") = "klick" Then
SQL2 = "SELECT * FROM files WHERE ( title like '1%' or title like '0%' or title like '2%' or title like '3%' or title like '4%' or title like '5%' or title like '6%' or title like '7%' or title like '8%' or title like '9%')"
if typ = "" then
else
SQL2 = SQL2 & "AND type = '"&typ&"' "
end if
SQL2 = SQL2 & " Order by click desc"
end if

rs2.Open SQL2, connection, adOpenStatic, adLockOptimistic

Set rs5 = Server.CreateObject("ADODB.Recordset")
SQL5 = "SELECT Count(id) as antal from files WHERE ( title like '1%' or title like '0%' or title like '2%' or title like '3%' or title like '4%' or title like '5%' or title like '6%' or title like '7%' or title like '8%' or title like '9%')"
if typ = "" then
else
SQL5 = SQL5 & "AND type = '"&typ&"'"
end if

rs5.Open SQL5, connection, adOpenStatic, adLockOptimistic

else

Set rs2 = Server.CreateObject("ADODB.Recordset")

If Request.QueryString("sort") = "" Then
SQL2 = "SELECT * FROM files WHERE ( title like '" & request("bokstav") & "%')"
if sektion = "" then
else
SQL2 = SQL2 & "AND type = '"&typ&"' "
end if
SQL2 = SQL2 & " Order by title,id Desc"
end if

If Request.QueryString("sort") = "typ" Then
SQL2 = "SELECT * FROM files WHERE ( title like '" & request("bokstav") & "%')"
if sektion = "" then
else
SQL2 = SQL2 & "AND type = '"&typ&"' "
end if
SQL2 = SQL2 & " Order by type"
end if

If Request.QueryString("sort") = "storlek" Then
SQL2 = "SELECT * FROM files WHERE ( title like '" & request("bokstav") & "%')"
if sektion = "" then
else
SQL2 = SQL2 & "AND type = '"&typ&"' "
end if
SQL2 = SQL2 & " Order by storlek"
end if

If Request.QueryString("sort") = "klick" Then
SQL2 = "SELECT * FROM files WHERE ( title like '" & request("bokstav") & "%')"
if sektion = "" then
else
SQL2 = SQL2 & "AND type = '"&typ&"' "
end if
SQL2 = SQL2 & " Order by click desc"
end if
rs2.Open SQL2, connection, adOpenStatic, adLockOptimistic

Set rs5 = Server.CreateObject("ADODB.Recordset")
SQL5 = "SELECT Count(id) as antal from files WHERE ( title like '" & request("bokstav") & "%')"
if sektion = "" then
else
SQL5 = SQL5 & "AND type = '"&typ&"'"
end if
rs5.Open SQL5, connection, adOpenStatic, adLockOptimistic
end if

sokresultat = rs5("antal")
rs5.close
set rs5=nothing
I = 0
If rs2.RecordCount = 0 Then
Response.Write("<font class=""text"">Hittade inga filer på bokstaven <b>"&request("bokstav")&"</b>.</font>")
Else
rs2.PageSize = 15
rs2.AbsolutePage = page
response.write("<font class=""text"">Hittade <b>"&sokresultat&"</b> filer på sökningen efter <b>"&request("bokstav")&"</b> i vår databas.</font><br><img height=""20"" src="""&url&"gfx/invisible.gif"" width=""1""><br>"&_
"<table border=""0"" width=""500"" cellspacing=""0"" cellpadding=""1"">"&_
"<tr bgcolor=""#003399"">"&_
"<td width=""60"" valign=""top""><a class=""f6"" href="""&url&"filarkiv/index.asp?sektion="&typ&"&bokstav="&request("bokstav")&"&sort=typ&page="&request("page")&"""><b>Typ</b></a></td>"&_
"<td width=""250"" valign=""top""><a class=""f6"" href="""&url&"filarkiv/index.asp?sektion="&typ&"&bokstav="&request("bokstav")&"&sort=&page="&request("page")&"""><b>Spel</b></a></td>"&_
"<td width=""100"" valign=""top""><a class=""f6"" href="""&url&"filarkiv/index.asp?sektion="&typ&"&bokstav="&request("bokstav")&"&sort=storlek&page="&request("page")&"""><b>Storlek</b></a></td>"&_
"<td width=""100"" valign=""top""><a class=""f6"" href="""&url&"filarkiv/index.asp?sektion="&typ&"&bokstav="&request("bokstav")&"&sort=klick&page="&request("page")&"""><b>Nerladdad</b></a></td>"&_
"<td width=""50"" valign=""top""><font class=""forum2""><b>Fil info</b></font></td>"&_
"</tr></table>"&_
"<table border=""0"" width=""500"" cellspacing=""0"" cellpadding=""0"">")
Do Until I = 15 Or rs2.eof

datum = rs2("datum")
s_day = Datepart("d", datum, vbmonday, vbFirstFourDays)
s_month = Datepart("m", datum, vbmonday, vbFirstFourDays)
s_year = Datepart("yyyy", datum, vbmonday, vbFirstFourDays)
s_hour = hour(datum)
s_minute = minute(datum)
if Len(s_hour) = 1 then
s_hour = 0&s_hour
end if
if Len(s_minute) = 1 then
s_minute = 0&s_minute
end if
if Len(s_month) = 1 then
s_month = 0&s_month
end if
datumformat = ""&s_day&"/"&s_month&" "&s_hour&":"&s_minute&""
response.write("<tr bgcolor=""#f0f0f0"">"&_
"<td width=""60"" valign=""top""><font class=""fusk"">"&rs2("type")&"</font></td>"&_
"<td width=""250"" valign=""top""><a class=""f1"" href="""&rs2("url")&""" onMouseOver=""window.status='http://www.fuskarna.nu/download/"&rs2("title")&".zip'; return true"" onMouseOut=""window.status=''; return true"" title=""Ladda ner "&rs2("title")&"!"" target=""_blank"">"&rs2("title")&"</a></td>"&_
"<td width=""120"" valign=""top""><font class=""fusk"">"&rs2("storlek")&"</td>"&_
"<td width=""100"" valign=""top""><font class=""fusk"">"&rs2("click")&"</td>"&_
"<td width=""50"" valign=""top""><a class=""f1"" href=""javascript:info('"&rs2("id")&"')"" class=""info"" target=""_self"">Info</a></td>"&_
"</tr>")
rs2.MoveNext
I = I + 1
Loop

response.write("<tr><td></td></tr></table>")

PageCount = CInt( rs2.PageCount )
If (page = 1) Then

If (PageCount>1) Then
response.write("<tr bgcolor=""#003399""><td align=""right""><a class=""f6"" href="""&url&"filarkiv/index.asp?sektion="&typ&"&bokstav="&request("bokstav")&"&page="&N&"&sort="&request("sort")&"""><b>Nästa</b></a></td></tr>")

else
response.write("<tr><td></td></tr>")
end if

elseif (page = PageCount) Then
response.write("<tr bgcolor=""#003399""><td align=""right""><a class=""f6"" href="""&url&"filarkiv/index.asp?sektion="&typ&"&bokstav="&request("bokstav")&"&page="&P&"&sort="&request("sort")&"""><b>Bakåt</b></a></td></tr>")

else

response.write("<tr bgcolor=""#003399""><td align=""right""><font class=""forum2""><a class=""f6"" href="""&url&"filarkiv/index.asp?sektion="&typ&"&bokstav="&request("bokstav")&"&page="&P&"&sort="&request("sort")&"""><b>Bakåt</b></a> | <a class=""f6"" href="""&url&"filarkiv/index.asp?sektion="&typ&"&bokstav="&request("bokstav")&"&page="&N&"&sort="&request("sort")&"""><b>Nästa</b></a></font></td></tr>")

end if

end if

rs2.close
set rs2 = nothing
connection.close
set connection = nothing

end if %>

LarsGMedlem sedan dec. 200012 465 inlägg
#2

På några ställen har du

if sektion = "" then

borde väl vara

if typ = "" then

Rent intuitivt så känns det som om man med ganska enkla medel skulle kunna skriva om koden så att ungefär 50% försvinner.

------------------
essentitia preter non sans multiplicandum

[Redigerat av LarsG den 15 nov 2001]

130 ms totalt · 3 externa anrop · cache AV · v20260731051352-full.56cc9887
0 ms — hämta statistik (cache)
0 ms — hämta forumlista (cache)
127 ms — hämta tråd, inlägg och bilagor (db)